fix(#in670): header color fixes

Conversation 0 Commits 1 Files Changed 21

denis.farber commented 2 years ago

Collaborator

https://insports.atlassian.net/browse/IN-670

denis.farber added 1 commit 2 years ago

e235cdf505 fix(#in670): header color fixes

denis.farber requested review from andrey.dekterev 2 years ago

denis.farber requested review from margarita.polyakova 2 years ago

roman.rakov reviewed 2 years ago

src/features/ProfileHeader/styled.tsx

													
					  color: string | undefined = DEFAULT_HEADER_COLOR,
				
					  headerImage: string | undefined | null,
				
					) => {
				
					  if ([

roman.rakov commented 2 years ago

Owner

думаю от подобной ерунды нужно избавляться, так как при добавлении новых клиентов приходится изменять и здесь.

andrey.dekterev commented 2 years ago

Owner

лучше будет так

color?: string

с остальными, где приписываем undefined, можно поступить так же

roman.rakov commented 2 years ago

Owner

я имел ввиду код который написан ниже

andrey.dekterev reviewed 2 years ago

src/requests/getPlayerInfo.tsx Outdated

													
					} from 'config'
				
					import { callApi } from 'helpers'
				
					import { TournamentType } from './getMatches'

andrey.dekterev commented 2 years ago

Owner

import type { TournamentType } from './getMatches'

margarita.polyakova approved these changes 2 years ago

margarita.polyakova reviewed 2 years ago

src/features/MatchCard/CardFrontside/MatchCardMobile/styled.tsx Outdated

													
					    gradientColor
				
					      ? css`
				
					          background: linear-gradient(
				
					            270deg,

margarita.polyakova commented 2 years ago

Collaborator

Поправь отступы, плз

src/features/MatchCard/styled.tsx Outdated

													
					  ${({ gradientColor }) => (
				
					    gradientColor
				
					      ? css`
				
					          background: linear-gradient(

margarita.polyakova commented 2 years ago

Collaborator

Отступы

src/features/ProfileHeader/index.tsx Outdated

													
					  const imageHeader = Boolean(profileWithImage[profileId])
				
					    && sportType === 1
				
					    && profileType === ProfileTypes.TOURNAMENTS ? `/images/${profileId}` : headerImage
				
					  && sportType === 1

margarita.polyakova commented 2 years ago

Collaborator

Здесь отступы нужно добавить

src/features/ProfileHeader/styled.tsx Outdated

													
					    || client.name === ClientNames.Fqtv
				
					    || client.name === ClientNames.Tunisia ? css`
				
					      background: ${color};
				
					           background: linear-gradient(

margarita.polyakova commented 2 years ago

Collaborator

Здесь тоже отступ поправить нужно

andrey.dekterev force-pushed IN-670-header-colors from e235cdf505 to 7a60acc12f 2 years ago

andrey.dekterev merged commit 7a60acc12f into develop 2 years ago

andrey.dekterev deleted branch IN-670-header-colors 2 years ago

Reviewers

andrey.dekterev was requested for review 2 years ago

margarita.polyakova approved these changes 2 years ago

continuous-integration/drone/push Build is passing

Details

The pull request has been merged as 7a60acc12f.

Sign in to join this conversation.

No Label

No Milestone

No Assignees

4 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: frontend/spa_instat_tv#254

fix(#in670): header color fixes #254

Reviewers