feat(vid-143): match download popup

margarita.polyakova commented 3 years ago

Collaborator

margarita.polyakova added 1 commit 3 years ago

margarita.polyakova requested review from andrey.dekterev 3 years ago

margarita.polyakova requested review from roman.rakov 3 years ago

andrey.dekterev reviewed 3 years ago

andrey.dekterev commented 3 years ago

Owner

чтобы не запускать лишний раз функцию, то лучше проверять на !teams и если его нет, то сразу возвращать null

margarita.polyakova commented 3 years ago

Poster

Collaborator

Здесь нельзя сделать проверку на !teams до запуска функции, т.к. тут еще идет проверка на tournaments и чего-то одного может не быть

andrey.dekterev commented 3 years ago

Owner

а если добавить проверку еще и турниров?

margarita.polyakova commented 3 years ago

Poster

Collaborator

Там будет ругаться на такую проверку if (!tournaments && !teams) return null

andrey.dekterev marked this conversation as resolved

roman.rakov approved these changes 3 years ago

andrey.dekterev approved these changes 3 years ago

andrey.dekterev merged commit 9990d8eec6 into develop 3 years ago

andrey.dekterev deleted branch VID-143-match-download-popup 3 years ago

roman.rakov approved these changes 3 years ago

andrey.dekterev approved these changes 3 years ago

continuous-integration/drone/push Build is passing

Details

The pull request has been merged as 9990d8eec6.

Sign in to join this conversation.

No Label

No Milestone

No Assignees

3 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: frontend/spa_instat_tv#213

       return checkDownloadData(teams, profile?.team1.id)
         || checkDownloadData(teams, profile?.team2.id)
     }

feat(vid-143): match download popup #213