fix(#578): back to live fix

Conversation 0 Commits 1 Files Changed 2

roman.rakov commented 3 years ago

Owner

https://insports.atlassian.net/browse/IN-578

roman.rakov added 1 commit 3 years ago

a232d6ef32 fix(#578 ): back to live fix

roman.rakov requested review from andrey.dekterev 3 years ago

roman.rakov requested review from denis.farber 3 years ago

denis.farber approved these changes 3 years ago

andrey.dekterev reviewed 3 years ago

src/features/StreamPlayer/hooks/index.tsx Outdated

andrey.dekterev reviewed 3 years ago

src/features/StreamPlayer/hooks/index.tsx Outdated

													
					    duration,
				
					    isLive,
				
					    playedProgress,
				
					    videoRefDurationMs,

andrey.dekterev commented 3 years ago

Owner

кажется это лишнее

roman.rakov commented 3 years ago

Poster

Owner

не хочется заного все это тестировать, все на своем месте)

andrey.dekterev commented 3 years ago

Owner

ну просто рефы бесполезно засовывать в зависимости

roman.rakov commented 3 years ago

Poster

Owner

это не реф, а число в итоге

roman.rakov added 1 commit 3 years ago

ea00f09c7e fix(#578 ): back to live fix

andrey.dekterev merged commit ea00f09c7e into develop 3 years ago

andrey.dekterev deleted branch in-578-back-to-live-fix 3 years ago

Reviewers

andrey.dekterev was requested for review 3 years ago

denis.farber approved these changes 3 years ago

continuous-integration/drone/push Build is passing

Details

The pull request has been merged as ea00f09c7e.

Sign in to join this conversation.

No Label

No Milestone

No Assignees

3 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: frontend/spa_instat_tv#197


				`const chaptersDuration = useDuration(chapters)`

				`const duration = (isLive && chapters[0]?.isFullMatchChapter)`

fix(#578): back to live fix #197

Reviewers