feat(in-570): episodes playback changes

Conversation 0 Commits 1 Files Changed 24

ruslan.khairullin commented 3 years ago

Collaborator

https://insports.atlassian.net/browse/IN-570

ruslan.khairullin added 1 commit 3 years ago

0750331e6a feat(in-570): episodes playback changes

ruslan.khairullin requested review from andrey.dekterev 3 years ago

ruslan.khairullin requested review from roman.rakov 3 years ago

andrey.dekterev reviewed 3 years ago

src/features/MultiSourcePlayer/hooks/index.tsx

andrey.dekterev commented 3 years ago

Owner

clearTimeout

ruslan.khairullin commented 3 years ago

Poster

Collaborator

mp4 все равно будет удаляться, код был написан до того как обсуждали об его удалении

andrey.dekterev marked this conversation as resolved

andrey.dekterev reviewed 3 years ago

src/features/StreamPlayer/hooks/index.tsx

andrey.dekterev commented 3 years ago

Owner

clearTimeout

ruslan.khairullin commented 3 years ago

Poster

Collaborator

это действие вызывается после клика пользователя, тут нет смысла делать clearTimeout, за 100 мс компонент не успеет размонтироваться

andrey.dekterev marked this conversation as resolved

andrey.dekterev approved these changes 3 years ago

roman.rakov approved these changes 3 years ago

andrey.dekterev merged commit 0750331e6a into develop 3 years ago

andrey.dekterev deleted branch in-570 3 years ago

Reviewers

andrey.dekterev approved these changes 3 years ago

roman.rakov approved these changes 3 years ago

continuous-integration/drone/push Build is passing

Details

The pull request has been merged as 0750331e6a.

Sign in to join this conversation.

No Label

No Milestone

No Assignees

3 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: frontend/spa_instat_tv#195

     disablePlayingEpisodes()
     backToPausedTime()
     restartVideo()
     setTimeout(() => {

     disablePlayingEpisodes()
     backToPausedTime()
     restartVideo()
     setTimeout(() => {

feat(in-570): episodes playback changes #195

Reviewers