frontend
/
spa_instat_tv
1
0
Fork 0
Code Pull Requests 1 Releases Wiki Activity
Labels Milestones

fix(#518): multiple tabs logout #192

Merged
roman.rakov merged 2 commits from in-518-multiple-tabs-logout into develop 3 years ago
Conversation 1 Commits 2 Files Changed 5
roman.rakov commented 3 years ago
Owner

https://insports.atlassian.net/browse/IN-518
https://insports.atlassian.net/browse/IN-572

https://insports.atlassian.net/browse/IN-518 https://insports.atlassian.net/browse/IN-572
roman.rakov added 1 commit 3 years ago
roman.rakov requested review from andrey.dekterev 3 years ago
roman.rakov requested review from ruslan.khairullin 3 years ago
ruslan.khairullin reviewed 3 years ago
src/features/AuthStore/hooks/useAuth.tsx Outdated
import { useHistory } from 'react-router'
import type { User } from 'oidc-client'
// @ts-ignore
ruslan.khairullin commented 3 years ago
Collaborator

@ts-expect-error

@ts-expect-error
roman.rakov marked this conversation as resolved
src/features/AuthStore/hooks/useAuth.tsx Outdated
setIsNewDeviceLogin,
])
duel.channel('active_page') // поле в LS, определяющее активность вкладки
ruslan.khairullin commented 3 years ago
Collaborator

будет выполняться при каждом рендере, может в useEffect один раз вызывать?

будет выполняться при каждом рендере, может в useEffect один раз вызывать?
roman.rakov commented 3 years ago
Poster
Owner

в некоторых браузерах он не срабатывает, если в useEffect засунуть

в некоторых браузерах он не срабатывает, если в useEffect засунуть
roman.rakov marked this conversation as resolved
ruslan.khairullin commented 3 years ago
Collaborator

подписку на обновление стораджа можно удалить

подписку на обновление стораджа можно удалить
andrey.dekterev approved these changes 3 years ago
package.json
"@stripe/stripe-js": "^1.13.2",
"babel-polyfill": "^6.26.0",
"date-fns": "^2.14.0",
"dueljs": "^1.2.7",
andrey.dekterev commented 3 years ago
Owner

а мы можем обойтись без того, чтобы не тянуть еще одну библиотеку?

а мы можем обойтись без того, чтобы не тянуть еще одну библиотеку?
roman.rakov marked this conversation as resolved
roman.rakov added 1 commit 3 years ago
continuous-integration/drone/push Build is passing
Details
b0b7ab6073 fix(#518): multiple tabs logout pr fix
ruslan.khairullin reviewed 3 years ago
ruslan.khairullin approved these changes 3 years ago
roman.rakov merged commit b0b7ab6073 into develop 3 years ago
roman.rakov deleted branch in-518-multiple-tabs-logout 3 years ago

Reviewers

andrey.dekterev approved these changes 3 years ago
ruslan.khairullin approved these changes 3 years ago
continuous-integration/drone/push Build is passing
Details
The pull request has been merged as b0b7ab6073.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
andrey.dekterev
ruslan.khairullin
Labels
Apply labels
Clear labels
No items
No Label
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: frontend/spa_instat_tv#192
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'in-518-multiple-tabs-logout'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes