feat(in-454): default landing

Conversation 0 Commits 2 Files Changed 17

margarita.polyakova commented 3 years ago

Collaborator

https://insports.atlassian.net/browse/IN-454

margarita.polyakova added 1 commit 3 years ago

a69fbe6c4b feat(in-454): default landing

margarita.polyakova requested review from andrey.dekterev 3 years ago

margarita.polyakova requested review from denis.farber 3 years ago

margarita.polyakova requested review from ruslan.khairullin 3 years ago

denis.farber approved these changes 3 years ago

ruslan.khairullin reviewed 3 years ago

src/features/Landings/hooks.tsx

													
					import { getLandingLogo } from 'requests/getLandingMedia'
				
					import { getTournamentInfo } from 'requests/getTournamentInfo'
				
					import { PAGES } from 'config/pages'

ruslan.khairullin commented 3 years ago

Collaborator

import { PAGES } from 'config'

src/features/Landings/index.tsx

													
					import map from 'lodash/map'
				
					import { isMobileDevice } from 'config/userAgent'

ruslan.khairullin commented 3 years ago

Collaborator

import { isMobileDevice } from 'config'

src/features/Landings/index.tsx

													
					              : (
				
					                <MainLogoWrapper>
				
					                  <LogoBackground />
				
					                  <MainLogoImg

ruslan.khairullin commented 3 years ago

Collaborator

можно задействовать компонент /src/features/Common/Image/index.tsx, там уже есть обработчик ошибок

src/features/TournamentPage/hooks.tsx Outdated

													
					import { openSubscribePopup, redirectToUrl } from 'helpers'
				
					import { PAGES } from 'config/pages'

ruslan.khairullin commented 3 years ago

Collaborator

import { PAGES } from 'config'

margarita.polyakova added 1 commit 3 years ago

c0a594d7c8 feat(in-454): pr fix

ruslan.khairullin approved these changes 3 years ago

andrey.dekterev approved these changes 3 years ago

andrey.dekterev merged commit c0a594d7c8 into develop 3 years ago

andrey.dekterev deleted branch IN-454-default-landing 3 years ago

Reviewers

denis.farber approved these changes 3 years ago

ruslan.khairullin approved these changes 3 years ago

andrey.dekterev approved these changes 3 years ago

continuous-integration/drone/push Build is passing

Details

The pull request has been merged as c0a594d7c8.

Sign in to join this conversation.

No Label

No Milestone

No Assignees

4 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: frontend/spa_instat_tv#160


				`import map from 'lodash/map'`

				`import { isMobileDevice } from 'config/userAgent'`


				`import { openSubscribePopup, redirectToUrl } from 'helpers'`

				`import { PAGES } from 'config/pages'`

feat(in-454): default landing #160

Reviewers