fix(#in503): google analylics ids added

Conversation 0 Commits 2 Files Changed 40

denis.farber commented 3 years ago

Collaborator

https://insports.atlassian.net/browse/IN-503

denis.farber added 1 commit 3 years ago

b7026e08bb fix(#in503): google analylics ids added

fix(#in503): more ids added

fix(#in503): more ids added and mobile fix

fix(#in503): min fix2

denis.farber requested review from andrey.dekterev 3 years ago

andrey.dekterev reviewed 3 years ago

src/features/StreamPlayer/components/Controls/Components/ControlsWeb/index.tsx Outdated

													
					          <PlayStop
				
					            playing={playing}
				
					            onClickCapture={togglePlaying}
				
					            id='match_video_start/stop'

andrey.dekterev commented 3 years ago

Owner

давайте тут лучше поменяем на match_video_start_stop, во избежание каких-либо проблем, если где-то в коде еще есть, то поменяй тоже на снейк кейс

👍 1

denis.farber added 1 commit 3 years ago

9205c61454 fix(#in503): comments fix

andrey.dekterev merged commit 9205c61454 into develop 3 years ago

andrey.dekterev deleted branch IN-503-google-analytics-ids 3 years ago

Reviewers

andrey.dekterev was requested for review 3 years ago

continuous-integration/drone/push Build is passing

Details

The pull request has been merged as 9205c61454.

Sign in to join this conversation.

No Label

No Milestone

No Assignees

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: frontend/spa_instat_tv#157

fix(#in503): google analylics ids added #157

Reviewers