frontend
/
spa_instat_tv
1
0
Fork 0
Code Pull Requests 1 Releases Wiki Activity
Labels Milestones

feat(in-424): statistics tour #148

Merged
andrey.dekterev merged 1 commits from in-424 into develop 3 years ago
Conversation 0 Commits 1 Files Changed 45
ruslan.khairullin commented 3 years ago
Collaborator

https://insports.atlassian.net/browse/IN-424

https://insports.atlassian.net/browse/IN-424
ruslan.khairullin requested review from andrey.dekterev 3 years ago
ruslan.khairullin requested review from margarita.polyakova 3 years ago
margarita.polyakova approved these changes 3 years ago
andrey.dekterev reviewed 3 years ago
src/features/MatchPage/components/MatchDescription/index.tsx Outdated
<Title>
<Title
// eslint-disable-next-line react/jsx-props-no-spreading
{...isMobileDevice && isOpen && {
andrey.dekterev commented 3 years ago
Owner

можем обойтись без спреда?

можем обойтись без спреда?
andrey.dekterev marked this conversation as resolved
andrey.dekterev reviewed 3 years ago
src/features/MatchPage/store/hooks/usePlayersStats.tsx Outdated
reduce<PlayersStats, Record<string, HeaderParam>>(
stats,
(acc, curr) => {
forEach(values(curr), ({
andrey.dekterev commented 3 years ago
Owner

попробуй переписать, чтобы сложность была хотя бы O(n), а не O(n^2)

попробуй переписать, чтобы сложность была хотя бы O(n), а не O(n^2)
andrey.dekterev marked this conversation as resolved
ruslan.khairullin force-pushed in-424 from 310704916f to c4403ea089 3 years ago
andrey.dekterev merged commit c4403ea089 into develop 3 years ago
andrey.dekterev deleted branch in-424 3 years ago

Reviewers

andrey.dekterev was requested for review 3 years ago
margarita.polyakova approved these changes 3 years ago
continuous-integration/drone/push Build is passing
Details
The pull request has been merged as c4403ea089.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
andrey.dekterev
margarita.polyakova
Labels
Apply labels
Clear labels
No items
No Label
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: frontend/spa_instat_tv#148
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'in-424'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes