IN-444-add-other-sports #139

Merged
andrey.dekterev merged 2 commits from IN-444-add-other-sports into develop 3 years ago
Owner
https://insports.atlassian.net/browse/IN-444
andrey.dekterev added 1 commit 3 years ago
andrey.dekterev requested review from roman.rakov 3 years ago
andrey.dekterev requested review from margarita.polyakova 3 years ago
andrey.dekterev requested review from ruslan.khairullin 3 years ago
ruslan.khairullin reviewed 3 years ago
const [sportsList, setSportsList] = useLocalStore<SportsType>({
defaultValue: {} as Sport,
key: querieKeys.sportsList,
validator: (val) => !!val,
Collaborator
validator: Boolean
``` validator: Boolean ```
andrey.dekterev marked this conversation as resolved
export const InputStyled = styled.input<InputProps>`
${inputStyles}
${inputStyles};
Collaborator

зачем ";" ?

зачем ";" ?
Poster
Owner

линтер ругался

линтер ругался
andrey.dekterev marked this conversation as resolved
key: filterKeys.DATE,
validator: isValidDate,
})
const sportList = JSON.parse(localStorage.getItem(querieKeys.sportsList)!)
Collaborator
  const sportList = JSON.parse(localStorage.getItem(querieKeys.sportsList) || '{}')

так будет безопаснее

``` const sportList = JSON.parse(localStorage.getItem(querieKeys.sportsList) || '{}') ``` так будет безопаснее
andrey.dekterev marked this conversation as resolved
export const getLexicFromSport = () => {
const sportList = getLocalStorageItem(querieKeys.sportsList)
const sportLexics = Object.values(sportList as Array<Sport>)
Collaborator
const sportLexics = Object.values(sportList as Array<Sport>)
.reduce((acc:LexicsConfig, cur: Sport) => {
  acc[cur?.lexic] = cur?.lexic;
  return acc;
}, {})

так лучше с точки зрения перфоманса

``` const sportLexics = Object.values(sportList as Array<Sport>) .reduce((acc:LexicsConfig, cur: Sport) => { acc[cur?.lexic] = cur?.lexic; return acc; }, {}) ``` так лучше с точки зрения перфоманса
andrey.dekterev marked this conversation as resolved
id={team.id}
name={team.name_en}
sportId={SportTypes.FOOTBALL}
sportId={1} // football
Collaborator

а у нас теперь не будет словаря, как узнать какой id спорта для хоккея например?

а у нас теперь не будет словаря, как узнать какой id спорта для хоккея например?
Poster
Owner

можно в локалсторадж зайти и посмотреть, там хранится инфа по всем видам спорта

можно в локалсторадж зайти и посмотреть, там хранится инфа по всем видам спорта
andrey.dekterev marked this conversation as resolved
export const getLocalStorageItem = (key: string) => {
const item = localStorage.getItem(key)!
Collaborator

а почему !, а если не будет ключа? лучше добавить проверку

а почему !, а если не будет ключа? лучше добавить проверку
andrey.dekterev marked this conversation as resolved
const sportsList = getLocalStorageItem(querieKeys.sportsList)
const sportsArray = Object.values(sportsList as Array<Sport>)
?.reduce((acc, cur) => {
if (cur.id === 1 || cur.id === 3) {
Collaborator
 if (icnludes([1, 2], cur.id)) {
``` if (icnludes([1, 2], cur.id)) { ```
andrey.dekterev marked this conversation as resolved
margarita.polyakova approved these changes 3 years ago
andrey.dekterev force-pushed IN-444-add-other-sports from 858ae3a313 to 38828ce816 3 years ago
andrey.dekterev removed review request for roman.rakov 3 years ago
andrey.dekterev force-pushed IN-444-add-other-sports from 38828ce816 to e43cbc2c02 3 years ago
ruslan.khairullin approved these changes 3 years ago
andrey.dekterev merged commit e43cbc2c02 into develop 3 years ago
andrey.dekterev deleted branch IN-444-add-other-sports 3 years ago

Reviewers

margarita.polyakova approved these changes 3 years ago
ruslan.khairullin approved these changes 3 years ago
continuous-integration/drone/push Build is passing
The pull request has been merged as e43cbc2c02.
Sign in to join this conversation.
No Label
No Milestone
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: frontend/spa_instat_tv#139
Loading…
There is no content yet.