refactor(#2818): fix comments from code review

keep-around/99001d5964a4727568711990575a9f282fe3f67e
Andrei Dekterev 3 years ago
parent 34ec3e8a5d
commit 82c96edf47
  1. 28
      src/features/MatchPage/components/FavouriteTeam/hooks.tsx
  2. 8
      src/features/MatchPage/components/FavouriteTeam/index.tsx

@ -54,31 +54,33 @@ const groupTeams = {
export const useFavouriteTeam = () => {
const [teams, setTeams] = useState<Array<FavouriteTeams>>([])
const [active, setActive] = useState<number | null>(null)
const [activeId, setActiveId] = useState<number | null>(null)
const [isOpen, setIsOpen] = useState<boolean>(false)
const [group1, setGroup1] = useState<Array<FavouriteTeams>>([])
const [group2, setGroup2] = useState<Array<FavouriteTeams>>([])
const changeActive = (team: FavouriteTeams) => {
setActive((prev) => (prev === team.id ? null : team.id))
setActiveId((prev) => (prev === team.id ? null : team.id))
}
const onSaveFavouriteTeam = () => {
active && saveFavouriteTeam(
activeId && saveFavouriteTeam(
{
answer_id: active,
answer_id: activeId,
survey_id: 1,
})
setIsOpen(false)
}
useEffect(() => {
getFavouriteTeam({
country_id: 77,
season: 30,
sport_id: 1,
tournament_id: 131,
}).then(({ data, status }: ResponseType) => {
useEffect( () => {
(async () => {
const { data, status }: ResponseType = await getFavouriteTeam({
country_id: 77,
season: 30,
sport_id: 1,
tournament_id: 131,
})
if(!status) {
setTeams(data.sort((n1:FavouriteTeams , n2: FavouriteTeams) => {
if (n1.name_en > n2.name_en) {
@ -92,7 +94,7 @@ export const useFavouriteTeam = () => {
}else{
return
}
})
})()
}, [])
useEffect(() => {
@ -105,7 +107,7 @@ export const useFavouriteTeam = () => {
}, [teams])
return {
active,
activeId,
changeActive,
group1,
group2,

@ -22,7 +22,7 @@ import {
export const FavouriteTeamPopup = () => {
const {
active,
activeId,
changeActive,
group1,
group2,
@ -45,7 +45,7 @@ export const FavouriteTeamPopup = () => {
<ScTeamsList>
{group1?.map((team: FavouriteTeams) => (
<ItemInfo
active={team.id === active}
active={team.id === activeId}
key={team.id}
id={team.id}
name={team.name_en}
@ -62,7 +62,7 @@ export const FavouriteTeamPopup = () => {
<ScTeamsList>
{group2?.map((team: FavouriteTeams) => (
<ItemInfo
active={team.id === active}
active={team.id === activeId}
key={team.id}
id={team.id}
name={team.name_en}
@ -74,7 +74,7 @@ export const FavouriteTeamPopup = () => {
</ScGroup>
</ScGroups>
<ButtonsBlock>
<Button disabled={!active} onClick={onSaveFavouriteTeam}>
<Button disabled={!activeId} onClick={onSaveFavouriteTeam}>
Ok
</Button>
</ButtonsBlock>

Loading…
Cancel
Save